Added SADD test variations discussed in redis/pull/11595 #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slice4e
approved these changes
Jan 19, 2023
zuiderkwast
reviewed
Jan 19, 2023
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Nice.
Although this benchmark is perhaps only useful for one PR. Every optimization needs its own special benchmark to prove it. What's your thoughts about that?
Contributor
Author
@zuiderkwast IMO it will still be useful to track SADD performance on a general benchmark ( we don't have specific sadd benchmarks on this spec yet ). So, lets add it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As being discussed in redis/redis#11595 (comment)